say we've got error for better developer usability #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We had problems with `npm ls` (deep in `haikro`) earlier today because it didn't output any indication that it had errors/issues. Only a bad return code that we didn't know about, made worse by the fact that it was `--log-leve=silence`. I realise that one reason for this design is for ease of integration & scriptability (string comparison with error output) but hey IMHO a bad error output is far better than a silent error output. :)
|
Hmmmmmmmmmm, we should think about this really carefully. I think to be safe we should make this a major version bump. Do you think it's worth doing? |
|
Why do you think it should this be a major version? It still fails in the same way but just outputs the error message, no? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had problems with
npm ls(deep inhaikro) earlier today because it didn't output any indication that it had errors/issues. Only a bad return code that we didn't know about, made worse by the fact that it was--log-leve=silence.I realise that one reason for this design is for ease of integration & scriptability (string comparison with error output) but hey IMHO a bad error output is far better than a silent error output. :)